feat: comments by Bennit99 · Pull Request #1685 · opencast/editor

Bennit99 · 2026-03-03T08:34:37Z

Adds a comment system for video editing like in the old admin UI.

Comments.tsx: Renders a scrollable list of comments with nested replies, timestamps, and status badges. Includes forms to add comments (with a required reason dropdown), reply, delete, and toggle resolved status.
commentSlice.ts: Manages local state for adding, deleting, and updating comments. Tracks uncommitted changes hasChanges and handles temporary local IDs.
Also configure a temporary vite dev proxy to bypass CORS for testing with loacal opencast instance
For testing create and delete some comments and replies

Issue: Feature Request: Make comments available

Adds a comment system for video editing. - Comments.tsx: Renders a scrollable list of comments with nested replies, timestamps, and status badges. Includes forms to add comments (with a required reason dropdown), reply, delete, and toggle resolved status. - commentSlice.ts: Manages local state for adding, deleting, and updating comments. Tracks uncommitted changes (\hasChanges\) and handles temporary local IDs.

github-actions · 2026-03-03T08:34:51Z

Hi @Bennit99
Thank you for contributing to the Opencast Editor.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

Form submitted - G

github-actions · 2026-03-03T08:36:39Z

This pull request is deployed at test.editor.opencast.org/1685/2026-03-27_08-12-36/ .
It might take a few minutes for it to become available.

gregorydlogan · 2026-03-05T04:59:49Z

For those curious, I have confirmed that this is a student at Munster.

github-actions · 2026-03-13T10:21:46Z

Hi @Bennit99
Thank you for contributing to the Opencast Editor.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

mtneug

Works as expected. Only some small comments from my side. Since I don't really work on the front-end, it would be great to also get a review from someone more familiar with the codebase.

public/editor-settings.toml

vite.config.ts

public/editor-settings.toml

src/main/MainMenu.tsx

This reverts commit 9dd6ba9b8bf6749c0fa5218696fa78a597f05605.

Co-authored-by: Matthias Neugebauer <mtneug@mailbox.org>

…velop

gregorydlogan

I'm not confident enough to review this properly. @Arnei can you, or delegate to someone who would be confident reviewing this?

gregorydlogan · 2026-04-13T22:23:26Z

public/editor-settings.toml

 show = true
+
+[comments]
+show = false


This should probably be true, since this config is what's backing editor.opencast.org and we want to show off all of the bells and whistles.

Arnei

Overall this looks very good to me! The stuff below is all pretty nitpicky.

I think I might have liked it better if the component was not quite as monolithic and split into more components, but I can see why you did that and it should not cause any trouble.

One thing I would like to see changed is the use of colors, namely I think there should be less of them. The color scheme of the editor is decidedly grayscale. Colors should not be used to make the ui look nice, but to explicitly draw the users attention to certain elements. For example, red signifies danger, so having the delete buttons in red makes sense to me. But the Submit/Reply/Cancel buttons at the bottom right do not require any color in my opinion. I'd say the same goes for the badges. Here there is also the additional issue that their color contrast to the background is quite low in light mode, making them hard to read.

Arnei · 2026-04-14T13:51:54Z

src/i18n/locales/en-US.json

    },

+    "comments": {
+      "no-comments": "No comments yet. Be the first to comment!",


Would make sense for a social media post or similar, but there is no reason to incentivize posting comments in Opencast. I think "No comments yet." is enough.

Arnei · 2026-04-14T13:52:58Z

src/main/Comments.tsx

+
+  // Handlers
+  const handleSaveComment = () => {
+    if (!settings.id || !newCommentText || !commentReason) {


Not like it is causing problems, but why are we checking for settings.id in the save handlers?

Arnei · 2026-04-14T14:20:41Z

src/main/Comments.tsx

+    // Modern scrollbar styling
+    "&::-webkit-scrollbar": {
+      width: "8px",
+      background: theme.background,
+    },
+    "&::-webkit-scrollbar-thumb": {
+      background: theme.text,
+      borderRadius: "5px",
+    },


This is not bad or anything, but definitely different from every other scrollbar in the editor. I don't think the stylistic inconsistency is worth it?

Arnei · 2026-04-14T15:03:13Z

src/main/Comments.tsx

+
+  return (
+    <div css={containerStyle}>
+      <h2 css={titleStyleBold(theme)}>{t("mainMenu.comments-button")}</h2>


For consistency with other views, could you center the title?

Arnei · 2026-04-15T07:30:53Z

src/main/Comments.tsx

+                      gap: "6px",
+                      fontSize: "0.9em",
+                      color: theme.text,
+                      opacity: 0.7,


Having a fixed opacity can lead to low contrast in the high-contrast color modes. You'll likely either want to make your opacity level a theme variable, or adjust your text color.

Arnei · 2026-04-15T09:19:50Z

src/main/Comments.tsx

+              <Select<{ value: string; label: string }>
+                styles={selectFieldStyle(theme)}
+                value={commentReason
+                  ? { value: commentReason, label: t(`comments.reasons.${commentReason}` as never) }


The more semantically correct type here would be ParseKeys from i18next. Might also make sense to type commentReason in a way that no typecast is needed? (same for the other two occurences of this)

Arnei · 2026-04-15T09:38:21Z

src/i18n/locales/en-US.json

+        "wrong_series_publication": "Wrong series or publication channel",
+        "wrong_workflow": "Wrong workflow",
+        "processing_failure": "Processing failure",
+        "admin_ui_notes": "Notes in Admin UI"


I think this should be adminui_notes?

Arnei · 2026-04-15T09:58:10Z

src/redux/commentSlice.ts

+        id: nanoid(),
+        creationDate: new Date().toISOString(),
+        author: "",  // Backend stamps the actual author via SecurityService
+        displayName: "",


Any chance we could have the display name of the current user here? It is a bit disorienting that new comments do not have the name of a user associated with them in the ui.

mtneug · 2026-04-15T11:49:51Z

FYI: I will take over the development of this PR as @Bennit99 sadly no longer works as a student for us. It might take some time, but I will work on the mentioned issues.

Bennit99 added 2 commits March 2, 2026 20:54

chore: configure vite dev proxy to bypass CORS

2dd6ba9

Bennit99 mentioned this pull request Mar 3, 2026

feat: editor comment support opencast/opencast#7452

Open

9 tasks

Arnei added the type:feature A new feature or feature request label Mar 4, 2026

mtneug requested changes Mar 20, 2026

View reviewed changes

public/editor-settings.toml Outdated Show resolved Hide resolved

vite.config.ts Outdated Show resolved Hide resolved

public/editor-settings.toml Outdated Show resolved Hide resolved

src/main/MainMenu.tsx Outdated Show resolved Hide resolved

Bennit99 and others added 4 commits March 22, 2026 22:35

Revert "chore: configure vite dev proxy to bypass CORS"

c1ec721

This reverts commit 9dd6ba9b8bf6749c0fa5218696fa78a597f05605.

comments flag set to false by default

0f6e182

Co-authored-by: Matthias Neugebauer <mtneug@mailbox.org>

remove optional chaining from settings.comments

40f554a

Merge branch 'develop' of github.com:Bennit99/opencast-editor into de…

1c1eaa6

…velop

Bennit99 force-pushed the develop branch from 1827477 to 73ead19 Compare March 24, 2026 07:20

use displayName for UI

72ae507

Bennit99 force-pushed the develop branch from 73ead19 to 72ae507 Compare March 27, 2026 08:12

gregorydlogan reviewed Apr 13, 2026

View reviewed changes

Arnei requested changes Apr 15, 2026

View reviewed changes

Conversation

Bennit99 commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 3, 2026 • edited by gregorydlogan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gregorydlogan commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

mtneug left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gregorydlogan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Arnei left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mtneug commented Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Bennit99 commented Mar 3, 2026 •

edited

Loading

github-actions bot commented Mar 3, 2026 •

edited by gregorydlogan

Loading

github-actions bot commented Mar 3, 2026 •

edited

Loading